[PATCH 26/34] staging: mt7621-mmc: Fix unmatched release_mem_regin

NeilBrown neil at brown.name
Tue Apr 3 07:48:03 UTC 2018


On Mon, Apr 02 2018, Christian Lütke-Stetzkamp wrote:

> Current code calls release_mem_regin on driver remove without
> requesting it explicit first. The region is only requested via
> devm_ioremap_resource and that releases it automatically. Removing the
> release_mem_region calls fixes this.
>
> Signed-off-by: Christian Lütke-Stetzkamp <christian at lkamp.de>
> ---
>  drivers/staging/mt7621-mmc/sd.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 82b983575394..9cc8f4c8ef28 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -2694,10 +2694,9 @@ static void msdc_init_gpd_bd(struct msdc_host *host, struct msdc_dma *dma)
>  
>  static int msdc_drv_probe(struct platform_device *pdev)
>  {
> -	struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	struct resource *res;
>  	__iomem void *base;
>  	struct mmc_host *mmc;
> -	struct resource *mem;
>  	struct msdc_host *host;
>  	struct msdc_hw *hw;
>  	int ret, irq;
> @@ -2713,11 +2712,11 @@ static int msdc_drv_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	hw   = (struct msdc_hw *)pdev->dev.platform_data;
> -	mem  = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	irq  = platform_get_irq(pdev, 0);
>  
>  	//BUG_ON((!hw) || (!mem) || (irq < 0)); /* --- by chhung */
>  
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0)

You need a ';' at the end of that line.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180403/cb9d415e/attachment-0001.asc>


More information about the devel mailing list