[PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()

KY Srinivasan kys at microsoft.com
Mon Sep 18 14:43:51 UTC 2017



> -----Original Message-----
> From: Greg KH [mailto:gregkh at linuxfoundation.org]
> Sent: Monday, September 18, 2017 7:00 AM
> To: KY Srinivasan <kys at microsoft.com>
> Cc: linux-kernel at vger.kernel.org; devel at linuxdriverproject.org;
> olaf at aepfle.de; apw at canonical.com; vkuznets at redhat.com;
> jasowang at redhat.com; leann.ogasawara at canonical.com;
> marcelo.cerri at canonical.com; Stephen Hemminger
> <sthemmin at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>
> Subject: Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in
> vmbus_hvsock_device_unregister()
> 
> On Sun, Sep 17, 2017 at 08:54:16PM -0700, kys at exchange.microsoft.com
> wrote:
> > From: Dexuan Cui <decui at microsoft.com>
> >
> > Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"),
> > we need this patch to resolve the below deadlock:
> >
> > after we get the mutex in vmbus_hvsock_device_unregister() and call
> > vmbus_device_unregister() -> device_unregister() -> ... ->
> device_release()
> > -> vmbus_device_release(), we'll get a deadlock, because
> > vmbus_device_release() tries to get the same mutex.
> >
> > Signed-off-by: Dexuan Cui <decui at microsoft.com>
> > Cc: K. Y. Srinivasan <kys at microsoft.com>
> > Cc: Haiyang Zhang <haiyangz at microsoft.com>
> > Cc: Stephen Hemminger <sthemmin at microsoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> 
> As every one of these patches had questions from me, please break them
> up into different series, one for 4.14-final, and one for 4.15-rc1.

Will do.

Thanks,

K. Y
> 
> thanks,
> 
> greg k-h


More information about the devel mailing list