[PATCH] staging: rtl8712: Fix unbalanced braces around else statement

[Frans Klaver]

On Tue, Sep 12, 2017 at 10:49 PM, Greg KH <gregkh at linuxfoundation.org> wrote:
> On Tue, Sep 12, 2017 at 01:40:15AM +0100, Liam Ryan wrote:
>> Fix checkpath-reported unbalanced braces in the following areas
>>
>> 221: FILE: drivers/staging/rtl8712/hal_init.c:221:
>> 392: FILE: drivers/staging/rtl8712/os_intfs.c:392:
>> 363: FILE: drivers/staging/rtl8712/rtl8712_cmd.c:363:
>> 889: FILE: drivers/staging/rtl8712/rtl8712_recv.c:889:
>> 902: FILE: drivers/staging/rtl8712/rtl871x_cmd.c:902:
>> 84: FILE: drivers/staging/rtl8712/rtl871x_ioctl_set.c:84:
>> 580: FILE: drivers/staging/rtl8712/rtl871x_mlme.c:580:
>> 593: FILE: drivers/staging/rtl8712/usb_intf.c:593:
>>
>> Signed-off-by: Liam Ryan <liamryandev at gmail.com>
>> ---
>> This is my first patch and I have several doubts about style choices
>>
>> At line 216 of hal_init.c should opening brace follow comment instead?
>>
>> At line 577 of rtl871x_mlme.c should I bring logic to one line instead of
>> opening the brace on the continued line?
>>
>> At line 353 of rtl8712_cmd.c the if/else is technically only 1 line each.
>> Should the braces still have been added per checkpath for readability?
>
> I have no idea about any of these, as I'm not going to take the time to
> dig in the source for it :)
>
> Try making up a patch and submit it and see what we think about it, it
> shouldn't be that hard.

I think these questions are about this patch.