[PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON

Pintu Kumar pintu_agarwal at yahoo.com
Sat Sep 9 15:56:26 UTC 2017


> On 09-Sep-2017, at 7:47 PM, Greg KH <gregkh at linuxfoundation.org> wrote:
> 
> On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote:
>> This patch is the fix for the below checkpatch issue:
>> CHECK: Avoid crashing the kernel - try using WARN_ON &
>> recovery code rather than BUG() or BUG_ON()
>> +	BUG();
>> 
>> Ideally this condition should never occur. But even if occurs
>> there is no point in crashing the whole kernel.
>> Just a warning should be enough to find the issue.
> 
> Nope, see the archives for when this has been rejected in the past.

Oh ok. Sorry I missed it.
I have the test cases about it. I will check and submit again (if required).

> 
> You can't just trivially replace BUG with WARN, otherwise it would have
> been done already :)
> 
> sorry,
> 
> greg k-h



More information about the devel mailing list