[PATCH 3/3] staging: rtlwifi: remove unused functions

[Greg Kroah-Hartman]

On Tue, Sep 05, 2017 at 09:46:55AM -0500, Larry Finger wrote:
> On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
> > Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
> > driver. Both functions call rtl_addr_delay(), this function is unused
> > outside of these call sites.The driver (and kernel) code base is cleaner
> > if unused functions are removed.
> > 
> > Remove unused functions.
> 
> While it is true that those routines are unused in the staging instance of
> rtlwifi, they are needed in the copy in drivers/net/wireless/... I would
> prefer to keep the differences between these two versions as small as
> possible; therefore, NACK

Huh?  No, you are not going to be able to keep those two trees in sync,
people are about to start to massivly attack drivers/staging/rtlwifi/
with coding style fixes and other such cleanups like this.  If you want
these to stay in "sync" then the driver should be using the in-kernel
versions of these "library" functions instead.

You aren't going to be able to NACK valid code cleanups here, sorry,
otherwise it's going to be a total mess...

So I'm going to take this patch in a few days...

thanks,

greg k-h