[PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers
Stephen Hemminger
stephen at networkplumber.org
Tue Oct 24 13:11:52 UTC 2017
On Fri, 20 Oct 2017 14:50:44 +0200
"gregkh at linuxfoundation.org" <gregkh at linuxfoundation.org> wrote:
> On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote:
> > On Fri, 6 Oct 2017 13:50:44 +0000
> > "Stahl, Manuel" <manuel.stahl at iis-extern.fraunhofer.de> wrote:
> >
> > > MSI(X) interrupts are not shared between devices. So when available
> > > those should be preferred over legacy interrupts.
> > >
> > > Signed-off-by: Manuel Stahl <manuel.stahl at iis.fraunhofer.de>
> > > ---
> > > drivers/uio/uio_pci_dmem_genirq.c | 27 ++++++++++++++++++++-------
> > > drivers/uio/uio_pci_generic.c | 24 ++++++++++++++++++------
> > > 2 files changed, 38 insertions(+), 13 deletions(-)
> >
> > The last time I tried to do MSI-X with pci-generic it got rejected
> > by the maintainer.
>
> Hm, yeah, this would break users today that do not have msi-x, right?
>
> Not good, Manuel, how well did you test this?
>
> thanks,
>
> greg k-h
Look at https://patchwork.kernel.org/patch/7303021/
The objection was more that UIO developers did not like that
UIO was (already) being used for DMA without IOMMU, and MSI-x has DMA because
of vector table.
More information about the devel
mailing list