[PATCH] staging: ccree: local variable "dev" not required

Joe Perches joe at perches.com
Thu Oct 5 18:00:31 UTC 2017


On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote:
> On Wed, Oct 4, 2017 at 10:12 PM,  <sunil.m at techveda.org> wrote:
> > There is no need to create a local pointer variable "dev" and
> > pass it various API's, instead use plat_dev which is enumerated
> > by platform core on successful probe.
[]
> I'm sorry but I don't understand what is the problem you are trying to solve or
> what is the improvement suggested.
> 
> Why is having a local variable undesirable? I think having it makes
> the code more readable, not less.

IMO: The local variable is _not_ undesirable.
     It does make the code more readable and
     shortens line lengths too.


More information about the devel mailing list