[PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

Miquel RAYNAL miquel.raynal at free-electrons.com
Thu Nov 30 22:02:46 UTC 2017


> > diff --git a/drivers/mtd/nand/nand_base.c
> > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095
> > 100644 --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd,
> > struct erase_info *instr, status = chip->erase(mtd, page &
> > chip->pagemask); 
> >  		/* See if block erase succeeded */
> > -		if (status & NAND_STATUS_FAIL) {
> > +		if (status) {
> >  			pr_debug("%s: failed erase, page 0x%08x\n",
> >  					__func__, page);
> >  			instr->state = MTD_ERASE_FAILED;  
> 
> You forgot to patch single_erase() accordingly.

Right, sorry about that, I will fix that.

Thanks,
Miquèl


More information about the devel mailing list