[PATCH] staging: lustre: Fix line over 80 characters

Greg KH gregkh at linuxfoundation.org
Tue Nov 28 14:18:59 UTC 2017


On Tue, Nov 28, 2017 at 05:13:55PM +0300, Dan Carpenter wrote:
> On Mon, Nov 27, 2017 at 03:36:58PM +0200, Talat Batheesh wrote:
> > This patch fix the line over 80 characters warning that was detected
> > using checkpatch.pl script.
> > 
> > Signed-off-by: Talat Batheesh <talat.b87 at gmail.com>
> > ---
> >  drivers/staging/lustre/lustre/obdclass/class_obd.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
> > index 2985bca..3e24b76 100644
> > --- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
> > +++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
> > @@ -377,7 +377,8 @@ static int obd_init_checks(void)
> >  	char buf[64];
> >  	int len, ret = 0;
> >  
> > -	CDEBUG(D_INFO, "LPU64=%s, LPD64=%s, LPX64=%s\n", "%llu", "%lld", "%#llx");
> > +	CDEBUG(D_INFO, "LPU64=%s, LPD64=%s, LPX64=%s\n", "%llu", "%lld",
> > +	       "%#llx");
> 
> No, that will break things.  Ignore string literals when dealing with
> the 80 character limit.

What will that break?  Yeah, it's a horrid line, but it should still
work...

thanks,

greg k-h


More information about the devel mailing list