[PATCH 3/3] staging: most: make DEVICE_ATTR structures static
Christian Gromm
christian.gromm at microchip.com
Mon Nov 27 14:20:06 UTC 2017
In order to limit the scope of the DEVICE_ATTR structure this patch
adds the keywork static.
Signed-off-by: Christian Gromm <christian.gromm at microchip.com>
---
drivers/staging/most/dim2/sysfs.c | 2 +-
drivers/staging/most/usb/usb.c | 30 +++++++++++++++---------------
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/most/dim2/sysfs.c b/drivers/staging/most/dim2/sysfs.c
index 7ead703..c85b2cd 100644
--- a/drivers/staging/most/dim2/sysfs.c
+++ b/drivers/staging/most/dim2/sysfs.c
@@ -21,7 +21,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
return sprintf(buf, "%s\n", state ? "locked" : "");
}
-DEVICE_ATTR_RO(state);
+static DEVICE_ATTR_RO(state);
static struct attribute *dev_attrs[] = {
&dev_attr_state.attr,
diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
index c72e9c3..8d23075 100644
--- a/drivers/staging/most/usb/usb.c
+++ b/drivers/staging/most/usb/usb.c
@@ -945,21 +945,21 @@ static ssize_t value_store(struct device *dev, struct device_attribute *attr,
return count;
}
-DEVICE_ATTR(ni_state, 0444, value_show, NULL);
-DEVICE_ATTR(packet_bandwidth, 0444, value_show, NULL);
-DEVICE_ATTR(node_address, 0444, value_show, NULL);
-DEVICE_ATTR(node_position, 0444, value_show, NULL);
-DEVICE_ATTR(sync_ep, 0200, NULL, value_store);
-DEVICE_ATTR(mep_filter, 0644, value_show, value_store);
-DEVICE_ATTR(mep_hash0, 0644, value_show, value_store);
-DEVICE_ATTR(mep_hash1, 0644, value_show, value_store);
-DEVICE_ATTR(mep_hash2, 0644, value_show, value_store);
-DEVICE_ATTR(mep_hash3, 0644, value_show, value_store);
-DEVICE_ATTR(mep_eui48_hi, 0644, value_show, value_store);
-DEVICE_ATTR(mep_eui48_mi, 0644, value_show, value_store);
-DEVICE_ATTR(mep_eui48_lo, 0644, value_show, value_store);
-DEVICE_ATTR(arb_address, 0644, value_show, value_store);
-DEVICE_ATTR(arb_value, 0644, value_show, value_store);
+static DEVICE_ATTR(ni_state, 0444, value_show, NULL);
+static DEVICE_ATTR(packet_bandwidth, 0444, value_show, NULL);
+static DEVICE_ATTR(node_address, 0444, value_show, NULL);
+static DEVICE_ATTR(node_position, 0444, value_show, NULL);
+static DEVICE_ATTR(sync_ep, 0200, NULL, value_store);
+static DEVICE_ATTR(mep_filter, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_hash0, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_hash1, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_hash2, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_hash3, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_eui48_hi, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_eui48_mi, 0644, value_show, value_store);
+static DEVICE_ATTR(mep_eui48_lo, 0644, value_show, value_store);
+static DEVICE_ATTR(arb_address, 0644, value_show, value_store);
+static DEVICE_ATTR(arb_value, 0644, value_show, value_store);
static struct attribute *dci_attrs[] = {
&dev_attr_ni_state.attr,
--
2.7.4
More information about the devel
mailing list