[PATCH 00/50] staging: most: rework driver architecture and fix defects

Christian Gromm christian.gromm at microchip.com
Mon Nov 27 13:38:34 UTC 2017


On 24.11.2017 16:31, Greg KH wrote:
> On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote:
>> This patch set fixes bugs and integrates the driver to the kernel's device
>> model by revising its architecture. Part of this change is rearranging the
>> directory layout, renaming of files and folders and thereby creating a
>> clean driver structure.
> 
> Ok I've now applied all of these to my testing branch.  I think you need
> to make some follow-up patches:
> 	- fix the build to actually compile the individual drivers :)
> 	- make DEVICE_ATTR structures static
> 	- use ATTRIBUTE_GROUPS where you can
> 	- use DEVICE_ATTR_RW() and _RO and _WO instead of a "raw"
> 	  DEVICE_ATTR() call.  There should not be any need to be having
> 	  any "special" file permissions for all of these attributes.

In driver/staging/most/usb/usb.c I can't use the DEVICE_ATTR_*
macros, unless we are willing to add a couple of extra function
wrappers. This is because I am using the same show and store
functions for all the attributes.

regards,
Chris




More information about the devel mailing list