[PATCH 00/50] staging: most: rework driver architecture and fix defects
Greg KH
gregkh at linuxfoundation.org
Fri Nov 24 15:11:34 UTC 2017
On Wed, Nov 22, 2017 at 06:30:42PM +0530, PrasannaKumar Muralidharan wrote:
> Hi Christian,
>
> On 21 November 2017 at 19:34, Christian Gromm
> <christian.gromm at microchip.com> wrote:
> > This patch set fixes bugs and integrates the driver to the kernel's device
> > model by revising its architecture. Part of this change is rearranging the
> > directory layout, renaming of files and folders and thereby creating a
> > clean driver structure.
> >
> >
> > Andrey Shvetsov (2):
> > staging: most: update driver usage file
> > staging: most: core: fix list traversing
> >
> > Christian Gromm (48):
> > staging: most: move core files
> > staging: most: cdev: rename module
> > staging: most: i2c: rename module
> > staging: most: dim2: rename module
> > staging: most: net: rename module
> > staging: most: sound: rename module
> > staging: most: usb: rename module
> > staging: most: video: rename module
> > staging: most: remove proprietary kobjects
> > staging: most: core: remove function get_channel_by_iface
> > staging: most: core: add a match function for the bus
> > staging: most: core: encapsulate code in function
> > staging: most: core: rename structure
> > staging: most: core: rename struct most_c_aim_obj to pipe
> > staging: most: core: rename struct memeber
> > staging: most: core: rename members aim* of struct most_channel
> > staging: most: core: use structure to pack driver specific data
> > staging: most: core: track aim modules with linked list
> > staging: most: core: fix sysfs attribute management
> > staging: most: core: remove struct device
> > staging: most: core: rename function
> > staging: most: core: replace struct most_inst_obj
> > staging: most: core: put channel name in struct most_channel
> > staging: most: core: remove context pointer
> > staging: most: usb: remove pointer initialization
> > staging: most: rename struct most_aim
> > staging: most: rename functions to register a driver with most_core
> > staging: most: core: rename mod_list
> > staging: most: core: rename aim variables
> > staging: most: core: rename function link_channel_to_aim
> > staging: most: net: remove aim designators
> > staging: most: sound: remove aim designator
> > staging: most: video: remove aim designators
> > staging: most: cdev: rename struct aim_channel
> > staging: most: cdev: rename variable aim_devno
> > staging: most: cdev: rename class instance aim_class
> > staging: most: cdev: rename variable cdev_aim
> > staging: most: fix comment sections
> > staging: most: core: denote modules as components
> > staging: most: core: fix formatting
> > staging: most: usb: clear functional stall on OUT endpoint
> > staging: most: core: fix data type
> > staging: most: core: check value returned by match function
> > staging: most: cdev: replace function prefix
> > staging: most: cdev: bundle module variables in structure
> > staging: most: core: remove class generation
> > staging: most: add ABI documentation
> > staging: most: usb: fix show/store function names
> >
> > .../most/Documentation/ABI/sysfs-bus-most.txt | 313 ++++
> > .../staging/most/Documentation/driver_usage.txt | 192 +-
> > drivers/staging/most/Kconfig | 27 +-
> > drivers/staging/most/Makefile | 5 +-
> > drivers/staging/most/aim-cdev/Makefile | 2 +-
> > drivers/staging/most/aim-network/Makefile | 2 +-
> > drivers/staging/most/aim-sound/Makefile | 2 +-
> > drivers/staging/most/aim-v4l2/Makefile | 2 +-
> > drivers/staging/most/{aim-cdev => cdev}/Kconfig | 6 +-
> > drivers/staging/most/cdev/Makefile | 4 +
> > drivers/staging/most/{aim-cdev => cdev}/cdev.c | 186 +-
> > drivers/staging/most/core.c | 1609 ++++++++++++++++
> > .../staging/most/{mostcore/mostcore.h => core.h} | 69 +-
> > drivers/staging/most/{hdm-dim2 => dim2}/Kconfig | 6 +-
> > drivers/staging/most/dim2/Makefile | 4 +
> > .../most/{hdm-dim2/dim2_hdm.c => dim2/dim2.c} | 31 +-
> > .../most/{hdm-dim2/dim2_hdm.h => dim2/dim2.h} | 2 +-
> > .../most/{hdm-dim2/dim2_errors.h => dim2/errors.h} | 2 +-
> > .../most/{hdm-dim2/dim2_hal.c => dim2/hal.c} | 8 +-
> > .../most/{hdm-dim2/dim2_hal.h => dim2/hal.h} | 4 +-
> > .../most/{hdm-dim2/dim2_reg.h => dim2/reg.h} | 2 +-
> > drivers/staging/most/dim2/sysfs.c | 55 +
> > .../most/{hdm-dim2/dim2_sysfs.h => dim2/sysfs.h} | 8 +-
> > drivers/staging/most/hdm-dim2/Makefile | 2 +-
> > drivers/staging/most/hdm-dim2/dim2_sysfs.c | 115 --
> > drivers/staging/most/hdm-i2c/Makefile | 2 +-
> > drivers/staging/most/hdm-usb/Makefile | 2 +-
> > drivers/staging/most/{hdm-i2c => i2c}/Kconfig | 6 +-
> > drivers/staging/most/i2c/Makefile | 4 +
> > .../staging/most/{hdm-i2c/hdm_i2c.c => i2c/i2c.c} | 11 +-
> > drivers/staging/most/mostcore/Kconfig | 14 -
> > drivers/staging/most/mostcore/Makefile | 3 -
> > drivers/staging/most/mostcore/core.c | 1949 --------------------
> > drivers/staging/most/{aim-network => net}/Kconfig | 6 +-
> > drivers/staging/most/net/Makefile | 4 +
> > .../most/{aim-network/networking.c => net/net.c} | 51 +-
> > drivers/staging/most/{aim-sound => sound}/Kconfig | 6 +-
> > drivers/staging/most/sound/Makefile | 4 +
> > drivers/staging/most/{aim-sound => sound}/sound.c | 25 +-
> > drivers/staging/most/{hdm-usb => usb}/Kconfig | 7 +-
> > drivers/staging/most/usb/Makefile | 4 +
> > .../staging/most/{hdm-usb/hdm_usb.c => usb/usb.c} | 264 +--
> > drivers/staging/most/{aim-v4l2 => video}/Kconfig | 6 +-
> > drivers/staging/most/video/Makefile | 4 +
> > drivers/staging/most/{aim-v4l2 => video}/video.c | 159 +-
> > 45 files changed, 2511 insertions(+), 2678 deletions(-)
> > create mode 100644 drivers/staging/most/Documentation/ABI/sysfs-bus-most.txt
> > rename drivers/staging/most/{aim-cdev => cdev}/Kconfig (70%)
> > create mode 100644 drivers/staging/most/cdev/Makefile
> > rename drivers/staging/most/{aim-cdev => cdev}/cdev.c (70%)
> > create mode 100644 drivers/staging/most/core.c
> > rename drivers/staging/most/{mostcore/mostcore.h => core.h} (86%)
> > rename drivers/staging/most/{hdm-dim2 => dim2}/Kconfig (83%)
> > create mode 100644 drivers/staging/most/dim2/Makefile
> > rename drivers/staging/most/{hdm-dim2/dim2_hdm.c => dim2/dim2.c} (98%)
> > rename drivers/staging/most/{hdm-dim2/dim2_hdm.h => dim2/dim2.h} (94%)
> > rename drivers/staging/most/{hdm-dim2/dim2_errors.h => dim2/errors.h} (95%)
> > rename drivers/staging/most/{hdm-dim2/dim2_hal.c => dim2/hal.c} (99%)
> > rename drivers/staging/most/{hdm-dim2/dim2_hal.h => dim2/hal.h} (98%)
> > rename drivers/staging/most/{hdm-dim2/dim2_reg.h => dim2/reg.h} (98%)
> > create mode 100644 drivers/staging/most/dim2/sysfs.c
> > rename drivers/staging/most/{hdm-dim2/dim2_sysfs.h => dim2/sysfs.h} (79%)
> > delete mode 100644 drivers/staging/most/hdm-dim2/dim2_sysfs.c
> > rename drivers/staging/most/{hdm-i2c => i2c}/Kconfig (72%)
> > create mode 100644 drivers/staging/most/i2c/Makefile
> > rename drivers/staging/most/{hdm-i2c/hdm_i2c.c => i2c/i2c.c} (98%)
> > delete mode 100644 drivers/staging/most/mostcore/Kconfig
> > delete mode 100644 drivers/staging/most/mostcore/Makefile
> > delete mode 100644 drivers/staging/most/mostcore/core.c
> > rename drivers/staging/most/{aim-network => net}/Kconfig (69%)
> > create mode 100644 drivers/staging/most/net/Makefile
> > rename drivers/staging/most/{aim-network/networking.c => net/net.c} (91%)
> > rename drivers/staging/most/{aim-sound => sound}/Kconfig (72%)
> > create mode 100644 drivers/staging/most/sound/Makefile
> > rename drivers/staging/most/{aim-sound => sound}/sound.c (97%)
> > rename drivers/staging/most/{hdm-usb => usb}/Kconfig (77%)
> > create mode 100644 drivers/staging/most/usb/Makefile
> > rename drivers/staging/most/{hdm-usb/hdm_usb.c => usb/usb.c} (86%)
> > rename drivers/staging/most/{aim-v4l2 => video}/Kconfig (71%)
> > create mode 100644 drivers/staging/most/video/Makefile
> > rename drivers/staging/most/{aim-v4l2 => video}/video.c (76%)
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > devel mailing list
> > devel at linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> Appreciate your effort in splitting up the patches. But reviewing 50
> patches is too difficult. It is extremely difficult to keep track of
> what 3rd patch does while looking at 21st patch. Can you send multiple
> patch series instead of one huge patch series?
What? No, 50 patches is just fine, if you can't review them all, then
don't :)
But there's going to be a new patch series anyway, it's good to get some
of them applied and then rebase and resend.
thanks,
greg k-h
More information about the devel
mailing list