[PATCH 47/50] staging: most: core: remove class generation

[PrasannaKumar Muralidharan]

Hi Christian,

On 21 November 2017 at 19:35, Christian Gromm
<christian.gromm at microchip.com> wrote:
> This patch stops the core from generating a module owned class and
> registering it with the kernel. It is needed, because there is no need for

Should be "It is not needed". Not is missing.

> a default MOST class to be present in the kernel.
>
> Signed-off-by: Christian Gromm <christian.gromm at microchip.com>
> ---
>  drivers/staging/most/core.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> index 72f1526..d03ff97 100644
> --- a/drivers/staging/most/core.c
> +++ b/drivers/staging/most/core.c
> @@ -39,7 +39,6 @@ static struct mostcore {
>         struct device dev;
>         struct device_driver drv;
>         struct bus_type bus;
> -       struct class *class;
>         struct list_head comp_list;
>  } mc;
>
> @@ -1564,17 +1563,10 @@ static int __init most_init(void)
>                 pr_info("Cannot register most bus\n");
>                 return err;
>         }
> -       mc.class = class_create(THIS_MODULE, "most");
> -       if (IS_ERR(mc.class)) {
> -               pr_info("No udev support.\n");
> -               err = PTR_ERR(mc.class);
> -               goto exit_bus;
> -       }
> -
>         err = driver_register(&mc.drv);
>         if (err) {
>                 pr_info("Cannot register core driver\n");
> -               goto exit_class;
> +               goto exit_bus;
>         }
>         mc.dev.init_name = "most_bus";
>         mc.dev.release = release_most_sub;
> @@ -1587,8 +1579,6 @@ static int __init most_init(void)
>
>  exit_driver:
>         driver_unregister(&mc.drv);
> -exit_class:
> -       class_destroy(mc.class);
>  exit_bus:
>         bus_unregister(&mc.bus);
>         return err;
> @@ -1599,7 +1589,6 @@ static void __exit most_exit(void)
>         pr_info("exit core module\n");
>         device_unregister(&mc.dev);
>         driver_unregister(&mc.drv);
> -       class_destroy(mc.class);
>         bus_unregister(&mc.bus);
>         ida_destroy(&mdev_id);
>  }
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Regards,
PrasannaKumar