[PATCH 1/2] vmbus: unregister device_obj->channels_kset

kys at exchange.microsoft.com kys at exchange.microsoft.com
Tue Nov 14 13:53:32 UTC 2017


From: Dexuan Cui <decui at microsoft.com>

Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")

Without the patch, a device can't be thoroughly destroyed, because
vmbus_device_register() -> kset_create_and_add() still holds a reference
to the hv_device's device.kobj.

Signed-off-by: Dexuan Cui <decui at microsoft.com>
Cc: Stephen Hemminger <sthemmin at microsoft.com>
Cc: stable at vger.kernel.org
Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 6a86746..4f3faf5 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1378,6 +1378,8 @@ void vmbus_device_unregister(struct hv_device *device_obj)
 	pr_debug("child device %s unregistered\n",
 		dev_name(&device_obj->device));
 
+	kset_unregister(device_obj->channels_kset);
+
 	/*
 	 * Kick off the process of unregistering the device.
 	 * This will call vmbus_remove() and eventually vmbus_device_release()
-- 
1.7.1



More information about the devel mailing list