[PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

Alex Elder elder at ieee.org
Tue Nov 7 15:07:25 UTC 2017

On 11/07/2017 08:47 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 07, 2017 at 08:42:07AM -0600, Alex Elder wrote:
>> On 11/07/2017 07:58 AM, Greg Kroah-Hartman wrote:
>>> It's good to have SPDX identifiers in all files to make it easier to
>>> audit the kernel tree for correct licenses.
>>> Update the drivers/staging/greybus files files with the correct SPDX
>>> license identifier based on the license text in the file itself.  The
>>> SPDX identifier is a legally binding shorthand, which can be used
>>> instead of the full boiler plate text.
>>> This work is based on a script and data from Thomas Gleixner, Philippe
>>> Ombredanne, and Kate Stewart.
>> Looks good.  Except...  Why the C++ style comment?  (Use /* */ not //?)
> That's the "style" that Linus wanted, it stands out, right?  :)

Yes it does.  I'm very happy to see SPDX getting deployed.	-Alex

> thanks for the review.
> greg k-h

More information about the devel mailing list