[PATCH v3 2/4] staging: greybus: loopback: Fix iteration count on async path

Bryan O'Donoghue pure.logic at nexus-software.ie
Mon Nov 6 01:32:20 UTC 2017


Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
support") does what it says on the tin - namely, adds support for
asynchronous bi-directional loopback operations.

What it neglects to do though is increment the per-connection
gb->iteration_count on an asynchronous operation error. This patch fixes
that omission.

Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")

Signed-off-by: Bryan O'Donoghue <pure.logic at nexus-software.ie>
Reported-by: Mitch Tasman <tasman at leaflabs.com>
Cc: Johan Hovold <johan at kernel.org>
Cc: Alex Elder <elder at kernel.org>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Mitch Tasman <tasman at leaflabs.com>
Cc: greybus-dev at lists.linaro.org
Cc: devel at driverdev.osuosl.org
Cc: linux-kernel at vger.kernel.org
---
 drivers/staging/greybus/loopback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 20d1b45..9c5980c 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -1021,8 +1021,10 @@ static int gb_loopback_fn(void *data)
 			else if (type == GB_LOOPBACK_TYPE_SINK)
 				error = gb_loopback_async_sink(gb, size);
 
-			if (error)
+			if (error) {
 				gb->error++;
+				gb->iteration_count++;
+			}
 		} else {
 			/* We are effectively single threaded here */
 			if (type == GB_LOOPBACK_TYPE_PING)
-- 
2.7.4



More information about the devel mailing list