[PATCH 1/2] staging: greybus: operation: add private data with get/set accessors

Johan Hovold johan at kernel.org
Sun Nov 5 12:19:02 UTC 2017


On Sun, Nov 05, 2017 at 03:27:38AM +0000, Bryan O'Donoghue wrote:
> Asynchronous operation completion handler's lives are made easier if there
> is a generic pointer that can store private data associated with the
> operation. This patch adds a pointer field to operation.h and get/set

As I mentioned in my review of v3 (back in January), this should be
s/operation.h/struct gb_operation/.

> methods to access that pointer.
> 
> Signed-off-by: Bryan O'Donoghue <pure.logic at nexus-software.ie>

Reviewed-by: Johan Hovold <johan at kernel.org>

> --- a/drivers/staging/greybus/operation.h
> +++ b/drivers/staging/greybus/operation.h
> @@ -105,6 +105,8 @@ struct gb_operation {
>  
>  	int			active;
>  	struct list_head	links;		/* connection->operations */
> +
> +	void			*private;
>  };

Johan


More information about the devel mailing list