[PATCH 2/7] staging: atomisp: Do not call dev_warn with a NULL device
Andy Shevchenko
andy.shevchenko at gmail.com
Sun May 28 13:06:20 UTC 2017
On Sun, May 28, 2017 at 3:31 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> Do not call dev_warn with a NULL device, this silence the following 2
> warnings:
>
> [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
> [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO
>
> We could switch to using pr_warn for dev == NULL instead, but as comments
> in the source indicate, the check for these 2 special gmin variables with
> a NULL device is a workaround for 2 specific evaluation boards, so
> completely silencing the missing warning for these actually is a good
> thing.
Perhaps removing all code related explicitly to Gmin is a right thing to do.
--
With Best Regards,
Andy Shevchenko
More information about the devel
mailing list