[PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

Greg KH gregkh at linuxfoundation.org
Fri May 19 08:20:41 UTC 2017


On Fri, May 19, 2017 at 01:42:55PM +0530, surenderpolsani at gmail.com wrote:
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> -		tsl2x7x_power_state_show, tsl2x7x_power_state_store);
> +static DEVICE_ATTR_RW(tsl2x7x_power_state);

You do realize you just renamed the sysfs file, changing the user/kernel
api?  That's generally not a good thing to ever do :(

thanks,

greg k-h


More information about the devel mailing list