[PATCH] staging: unisys: Solve sparse warning
Kershner, David A
David.Kershner at unisys.com
Wed May 3 15:20:36 UTC 2017
> -----Original Message-----
> From: Marcos Paulo de Souza [mailto:marcos.souza.org at gmail.com]
> Sent: Tuesday, May 2, 2017 11:28 PM
> Cc: Marcos Paulo de Souza <marcos.souza.org at gmail.com>; Kershner, David
> A <David.Kershner at unisys.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; Sell, Timothy C <Timothy.Sell at unisys.com>;
> Binder, David Anthony <David.Binder at unisys.com>; Erik Arfvidson
> <erik.arfvidson at unisys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar at unisys.com>; Curtin, Alexander Paul
> <Alexander.Curtin at unisys.com>; *S-Par-Maintainer
> <SParMaintainer at unisys.com>; devel at driverdev.osuosl.org; linux-
> kernel at vger.kernel.org
> Subject: [PATCH] staging: unisys: Solve sparse warning
>
> The following commit fixes the following sparse report:
>
> drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
> restricted __le64
>
> by casting readq (which is unsigned long on x86) to u64, as expected by the
> seq_printf call.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
> ---
> Just compiled tested on x86_64.
>
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 6997b16..46d33e6 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -657,7 +657,7 @@ static int info_debugfs_show(struct seq_file *seq,
> void *v)
> seq_printf(seq, "phys_flags_addr = 0x%016llx\n",
> phys_flags_addr);
> seq_printf(seq, "FeatureFlags = %llu\n",
> - (__le64)readq(devdata->flags_addr));
> + (u64)readq(devdata->flags_addr));
Acked-by: David Kershner <david.kershner at unisys.com>
> }
> seq_printf(seq, "acquire_failed_cnt = %llu\n",
> devdata->acquire_failed_cnt);
> --
> 2.9.3
More information about the devel
mailing list