[RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues.

Greg KH gregkh at linuxfoundation.org
Wed Mar 22 20:42:49 UTC 2017


On Wed, Mar 22, 2017 at 12:20:23PM -0700, Arushi Singhal wrote:
> On Tuesday, March 21, 2017 at 5:12:41 PM UTC+5:30, Arushi Singhal wrote:
> 
>     Improve readability by fixing multiple checkpatch.pl
>     issues in speakup driver.
> 
>     Arushi Singhal (11):
>       staging: speakup: Moved logical to previous line.
>       staging: speakup: Remove multiple assignments
>       staging: speakup: Simplify "NULL" comparisons
>       staging: speakup: fixes braces {} should be used on all arms of this
>         statement
>       staging: speakup: Remove multiple assignments
>       staging: speakup: Moved OR operator to previous line.
>       staging: speakup: spaces preferred around operator
>       staging: speakup: Removed Unnecessary parentheses.
>       staging: speakup: Simplify the NULL comparisons
>       staging: speakup: Match alignment with open parenthesis.
>       staging: speakup: Fix alignment with parenthesis.
> 
>      drivers/staging/speakup/fakekey.c        |   2 +-
>      drivers/staging/speakup/kobjects.c       |   2 +-
>      drivers/staging/speakup/main.c           | 110
>     +++++++++++++++++--------------
>      drivers/staging/speakup/selection.c      |   4 +-
>      drivers/staging/speakup/serialio.c       |   2 +-
>      drivers/staging/speakup/speakup.h        |  12 ++--
>      drivers/staging/speakup/speakup_acntpc.c |   8 +--
>      drivers/staging/speakup/speakup_apollo.c |   2 +-
>      drivers/staging/speakup/speakup_decext.c |  10 +--
>      drivers/staging/speakup/speakup_decpc.c  |  26 ++++----
>      drivers/staging/speakup/speakup_dectlk.c |   6 +-
>      drivers/staging/speakup/speakup_dtlk.c   |   2 +-
>      drivers/staging/speakup/speakup_keypc.c  |   6 +-
>      drivers/staging/speakup/speakup_ltlk.c   |   2 +-
>      drivers/staging/speakup/varhandlers.c    |  18 ++---
>      15 files changed, 114 insertions(+), 98 deletions(-)
> 
> 
> Hi
> Any update on these patches?

One day?  Please give us a chance, realize that it's normally a 2 week
timeframe to get a patch reviewed...

thanks,

greg k-h


More information about the devel mailing list