[PATCH] staging: dgnc: fix printk warnings in dgnc_tty.c

Greg KH greg at kroah.com
Tue Mar 21 07:51:19 UTC 2017


On Sun, Mar 19, 2017 at 03:46:11AM -0700, abshkbh at gmail.com wrote:
> From: Abhishek Bhardwaj <abshkbh at gmail.com>
> 
> Use __func__ to print dgnc_tty_send_xchar function name.
> 
> Signed-off-by: Abhishek Bhardwaj <abshkbh at gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index cde00e3702fa..3d2274f68ac6 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -1862,13 +1862,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
>  	if (!bd || bd->magic != DGNC_BOARD_MAGIC)
>  		return;
>  
> -	dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
> +	dev_dbg(tty->dev, "%s start\n", __func__);
>  
>  	spin_lock_irqsave(&ch->ch_lock, flags);
>  	bd->bd_ops->send_immediate_char(ch, c);
>  	spin_unlock_irqrestore(&ch->ch_lock, flags);
>  
> -	dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n");
> +	dev_dbg(tty->dev, "%s finish\n", __func__);

These "start" and "finished" messages need to just be deleted from the
driver entirely.  There is no need for them, now that we have ftrace in
the kernel (this driver predates that.)

Can you just remove them all instead?

thanks,

greg k-h


More information about the devel mailing list