[PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

kbuild test robot lkp at intel.com
Tue Mar 21 03:54:19 UTC 2017


Hi unknown,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.11-rc3 next-20170320]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/unknown/staging-radio-bcm2048-Fix-checkpatch-warnings-WARNING-Prefer-unsigned-int-to-bare-use-of-unsigned/20170321-105721
base:   git://linuxtv.org/media_tree.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_power_state_write':
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2031:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_mute_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:43: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
                                              ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_audio_route_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_dac_output_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:49: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
                                                    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_hi_lo_injection_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2036:57: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
                                                            ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2036:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2037:51: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
                                                      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2037:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_af_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2038:54: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
                                                         ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2038:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_deemphasis_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2039:52: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
                                                       ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2039:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_rds_mask_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2040:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2040:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_best_tune_mode_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2041:56: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
                                                           ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
     type value;       \
     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:2041:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_search_rssi_threshold_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2042:63: error: two or more data types in declaration specifiers

vim +2031 drivers/staging/media/bcm2048/radio-bcm2048.c

  2025										\
  2026		kfree(out);							\
  2027										\
  2028		return count;							\
  2029	}
  2030	
> 2031	DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
  2032	DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
  2033	DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
  2034	DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 49084 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20170321/cd2c0daf/attachment-0001.bin>


More information about the devel mailing list