[PATCH 10/12] staging: ks7010: fix checkpatch memset warning
Dan Carpenter
dan.carpenter at oracle.com
Tue Mar 14 11:08:17 UTC 2017
On Tue, Mar 14, 2017 at 09:44:07PM +1100, Tobin C. Harding wrote:
> On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote:
> > This code is #ifdeffed out so you should just delete it instead of
> > fixing it.
>
> The TODO file specifically asks for ifdeffed code not to be removed unless
> one knows exactly what is going on. I hope to get to that level but am
> not there yet.
Normally we just delete it. I've never yet regretted doing that. It's
still in the git log if people need it.
Don't be a hoarder.
regards,
dan carpenter
More information about the devel
mailing list