[PATCH 2/2] staging: bcm2835-audio: Disable extra virtual cards by default

Michael Zoran mzoran at crowfest.net
Tue Mar 14 08:55:01 UTC 2017


On Tue, 2017-03-14 at 09:17 +0100, Stefan Wahren wrote:
> Am 14.03.2017 um 07:45 schrieb Michael Zoran:
> > The extra virtual cards created for HDMI and Headphone output
> > may not be compatible with operating systems that expose
> > very simple audio controls.
> > 
> > By default only enable the traditional mode that exposes a single
> > card for maximum compatibility.
> > 
> > Add options to the build configuration for enabling the extra
> > virtual cards.
> 
> This looks like a workaround for broken applications. Could please
> you
> name them?
> 
> Btw avoid those many #if defined(). They are bad for readibility and
> compile test. Sometimes a single IS_ENABLED() at the right place is
> better.

I did all my testing on debian sid which has rather complex and
detailed controls with pulseaudio.  But Raspbian has a custom simple
mixer and I'm concerned about breaking that.  I didn't want to name
names.

I know of other operating systems designed specifically for the RPI for
multimedia that I don't use, so I'm a bit concerned about breaking
those as well.

Honestly, it would be cool to have just the HDMI and Headphone virtual
devices, but I'm not sure I'm confident enough in my testing yet to
drop the traditional device yet.




More information about the devel mailing list