patch "staging: dgnc: remove item from TODO list" added to staging-next

[Tobin C. Harding]

On Sun, Mar 12, 2017 at 11:02:41PM +0100, Greg KH wrote:
> On Mon, Mar 13, 2017 at 07:50:42AM +1100, Tobin C. Harding wrote:
> > On Sun, Mar 12, 2017 at 05:24:38PM +0100, gregkh at linuxfoundation.org wrote:
> > > 
> > > This is a note to let you know that I've just added the patch titled
> > > 
> > >     staging: dgnc: remove item from TODO list
> > > 
> > > to my staging git tree which can be found at
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > in the staging-next branch.
> > > 
> > > The patch will show up in the next release of the linux-next tree
> > > (usually sometime within the next 24 hours during the week.)
> > > 
> > > The patch will also be merged in the next major kernel release
> > > during the merge window.
> > > 
> > > If you have any questions about this process, please let me know.
> > > 
> > > 
> > > From 2437a9e023fe1df77c053b222762357bb73212e8 Mon Sep 17 00:00:00 2001
> > > From: "Tobin C. Harding" <me at tobin.cc>
> > > Date: Tue, 7 Mar 2017 20:57:04 +1100
> > > Subject: staging: dgnc: remove item from TODO list
> > > 
> > > TODO file contains task to verify and correct function return
> > > sites. Need to check for and implement correct usage of goto's when
> > > there is work to be done before returning.
> > > 
> > > Remove task from TODO list after already having completed audit of
> > > directory drivers/staging/dgnc.
> > > 
> > > Signed-off-by: Tobin C. Harding <me at tobin.cc>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > > ---
> > >  drivers/staging/dgnc/TODO | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
> > > index e26d1d6a5941..d3806bebbcb5 100644
> > > --- a/drivers/staging/dgnc/TODO
> > > +++ b/drivers/staging/dgnc/TODO
> > > @@ -1,7 +1,6 @@
> > >  * remove unnecessary comments
> > >  * remove unnecessary error messages. Example kzalloc() has its
> > >    own error message. Adding an extra one is useless.
> > > -* use goto statements for error handling when appropriate
> > >  * there is a lot of unnecessary code in the driver. It was
> > >    originally a standalone driver. Remove unneeded code.
> > >  
> > > -- 
> > > 2.12.0
> > > 
> > > 
> > 
> > Greg, sorry to start your Monday with unnecessary complications. This
> > patch series has been applied, it was v2 of a series. I had a v3 done
> > on Friday that I did not get to sending.
> 
> How was I supposed to know that there was a v3 coming?  I didn't see
> that in any thread that I happened to have around :(
> 
> > It has improvements based on a few back and forth comments with Dan. I
> > would like to still get his suggestions implemented. My fear is that
> > the patch set that will apply on top of staging-next now is going to
> > seem a bit trivial if viewed without the context of the original patch
> > set. Also there will be no checkpatch warnings to justify the changes.
> > 
> > Did I do something wrong that led to this series being applied before
> > it was totally ready? Was there something that I should have done to
> > let you know that there was still work to be done on top of version 2?
> 
> Yes, respond to the patch thread that says "drop this series!"

Got it.

> > What is the easiest way forward for you? 
> 
> Send me fixes on top of what is now in my tree please.  I'm not
> reverting them, and I can't rebase.

No problem, will do.

thanks,
Tobin.