[PATCH] staging: atomisp: remove redundant check for client being null

Colin King colin.king at canonical.com
Sat Mar 11 19:48:19 UTC 2017


From: Colin Ian King <colin.king at canonical.com>

The previous statement checks if client is null, so the null check
when assigning dev is redundant and can be removed.

Detected by CoverityScan, CID#1416555 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 .../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
index 65513ca..2929492 100644
--- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
@@ -354,7 +354,7 @@ static struct gmin_subdev *gmin_subdev_add(struct v4l2_subdev *subdev)
 	if (!client)
 		return NULL;
 
-	dev = client ? &client->dev : NULL;
+	dev = &client->dev;
 
 	for (i=0; i < MAX_SUBDEVS && gmin_subdevs[i].subdev; i++)
 		;
-- 
2.10.2



More information about the devel mailing list