[PATCH 08/12] staging: ks7010: fix spelling of Michael MIC
Tobin C. Harding
me at tobin.cc
Wed Mar 8 08:44:41 UTC 2017
On Wed, Mar 08, 2017 at 08:54:39AM +0300, Dan Carpenter wrote:
> On Wed, Mar 08, 2017 at 02:36:53PM +1100, Tobin C. Harding wrote:
> > Various symbols are named 'michel*'. The keyed hash function name is
> > spelled 'Michael'.
> >
> > Rename symbols michel -> michael.
> >
> > Signed-off-by: Tobin C. Harding <me at tobin.cc>
> > ---
> > drivers/staging/ks7010/ks_hostif.c | 16 ++++++++--------
> > drivers/staging/ks7010/michael_mic.c | 8 ++++----
> > drivers/staging/ks7010/michael_mic.h | 4 ++--
> > 3 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > index edeefea..4256b10 100644
> > --- a/drivers/staging/ks7010/ks_hostif.c
> > +++ b/drivers/staging/ks7010/ks_hostif.c
> > @@ -316,7 +316,7 @@ int hostif_data_indication_wpa(struct ks_wlan_private *priv, unsigned int auth_t
> > char buf[128];
> > unsigned long now;
> > struct mic_failure_t *mic_failure;
> > - struct michel_mic_t michel_mic;
> > + struct mihcael_mic_t mihcael_mic;
>
>
> Nope.
Does MichelMIC not refer to the Michael hashed key function referred
to here?:
https://en.wikipedia.org/wiki/Temporal_Key_Integrity_Protocol
and in this paper:
http://www.uow.edu.au/~jennie/WEB/WEB05/Michael.pdf
Both spellings (michel + michael) are present in
drivers/staging/ks7010/
staging/drivers/ks7010/michael_mic.h (note file name spelling):
/* MichelMIC routine define */
struct michel_mic_t {
u32 K0; // Key
u32 K1; // Key
u32 L; // Current state
u32 R; // Current state
u8 M[4]; // Message accumulator (single word)
int nBytesInM; // # bytes in M
u8 Result[8];
};
void MichaelMICFunction(struct michel_mic_t *Mic, u8 *Key,
u8 *Data, int Len, u8 priority,
u8 *Result);
thanks,
Tobin.
More information about the devel
mailing list