[PATCH] vmbus: re-enable tasklet

KY Srinivasan kys at microsoft.com
Fri Jun 30 03:27:14 UTC 2017



> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces at linuxdriverproject.org] On
> Behalf Of KY Srinivasan
> Sent: Thursday, June 29, 2017 4:36 PM
> To: Stephen Hemminger <stephen at networkplumber.org>; Haiyan Yang
> <haiyang at microsoft.com>
> Cc: devel at linuxdriverproject.org; stable at vger.kernel.org
> Subject: RE: [PATCH] vmbus: re-enable tasklet
> 
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > Sent: Thursday, June 29, 2017 4:31 PM
> > To: KY Srinivasan <kys at microsoft.com>; Haiyan Yang
> > <haiyang at microsoft.com>
> > Cc: devel at linuxdriverproject.org; stable at vger.kernel.org; Greg KH
> > <greg at kroah.com>
> > Subject: Re: [PATCH] vmbus: re-enable tasklet
> >
> > On Thu, 22 Jun 2017 16:16:54 -0700
> > Stephen Hemminger <stephen at networkplumber.org> wrote:
> >
> > > This problem shows up in 4.11 when netvsc driver is removed and
> > reloaded.
> > > The problem is that the channel is closed during module removal and the
> > > tasklet for processing responses is disabled. When module is reloaded
> > > the channel is reopened but the tasklet is marked as disabled.
> > >
> > > Patch for upstream is pending, but less urgent since problem doesn't
> > > happen with network driver in 4.12.
> > >
> > > Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
> > > ---
> > >  drivers/hv/channel.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> > > index 321b8833fa6f..36c9ce191b74 100644
> > > --- a/drivers/hv/channel.c
> > > +++ b/drivers/hv/channel.c
> > > @@ -606,6 +606,8 @@ static int vmbus_close_internal(struct
> > vmbus_channel *channel)
> > >  		get_order(channel->ringbuffer_pagecount * PAGE_SIZE));
> > >
> > >  out:
> > > +	/* re-enable tasklet for use on re-open */
> > > +	tasklet_enable(&channel->callback_event);
> > >  	return ret;
> > >  }
> > >
> >
> > Ping.
> >
> > What is the state of this patch? Why is it not queued for 4.11 stable?
> 
> I will submit this shortly.
> 
> K. Y

Looks like I have already tagged the patch for "stable"

K. Y
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdriverd
> ev.linuxdriverproject.org%2Fmailman%2Flistinfo%2Fdriverdev-
> devel&data=02%7C01%7Ckys%40microsoft.com%7C13413d4ede084b455e74
> 08d4bf479602%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636343
> 761559957369&sdata=aTcCIkpVDcwMIiZIavf2pvYdqdBQLhBuIStgb4%2FI%2FC
> 4%3D&reserved=0


More information about the devel mailing list