[PATCH V2] staging: unisys: visorhba - style fix
Kershner, David A
David.Kershner at unisys.com
Mon Jun 19 15:28:19 UTC 2017
> -----Original Message-----
> From: Derek Robson [mailto:robsonde at gmail.com]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A <David.Kershner at unisys.com>;
> gregkh at linuxfoundation.org; Sell, Timothy C <Timothy.Sell at unisys.com>;
> Binder, David Anthony <David.Binder at unisys.com>; Wadgaonkar, Sameer
> Laxmikant <Sameer.Wadgaonkar at unisys.com>;
> marcos.souza.org at gmail.com; robsonde at gmail.com
> Cc: *S-Par-Maintainer <SParMaintainer at unisys.com>;
> devel at driverdev.osuosl.org; linux-kernel at vger.kernel.org
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde at gmail.com>
I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit.
>
> V1 has vauge subject
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> goto err_scsi_remove_host;
> }
> devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
> devdata->debugfs_dir, devdata,
> &info_debugfs_fops);
> if (!devdata->debugfs_info) {
> --
> 2.13.0
More information about the devel
mailing list