[PATCH] staging: lustre: llite: Make structure describing various file operations 'const'

Roman Storozhenko romeusmeister at gmail.com
Sat Jun 10 11:31:17 UTC 2017


On Sat, Jun 10, 2017 at 01:16:50PM +0800, kbuild test robot wrote:
> Hi Roman,
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.12-rc4 next-20170609]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Roman-Storozhenko/staging-lustre-llite-Make-structure-describing-various-file-operations-const/20170610-121428
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/staging/lustre/lustre/llite/file.c:3117:8: error: expected '{' before 'const'
>     struct const file_operations ll_file_operations = {
>            ^~~~~
>    drivers/staging/lustre/lustre/llite/file.c:3130:8: error: expected '{' before 'const'
>     struct const file_operations ll_file_operations_flock = {
>            ^~~~~
>    drivers/staging/lustre/lustre/llite/file.c:3146:8: error: expected '{' before 'const'
>     struct const file_operations ll_file_operations_noflock = {
>            ^~~~~
>    drivers/staging/lustre/lustre/llite/file.c:2706:1: warning: 'll_file_noflock' defined but not used [-Wunused-function]
>     ll_file_noflock(struct file *file, int cmd, struct file_lock *file_lock)
>     ^~~~~~~~~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:2408:1: warning: 'll_file_flock' defined but not used [-Wunused-function]
>     ll_file_flock(struct file *file, int cmd, struct file_lock *file_lock)
>     ^~~~~~~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:2281:12: warning: 'll_flush' defined but not used [-Wunused-function]
>     static int ll_flush(struct file *file, fl_owner_t id)
>                ^~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:2259:15: warning: 'll_file_seek' defined but not used [-Wunused-function]
>     static loff_t ll_file_seek(struct file *file, loff_t offset, int origin)
>                   ^~~~~~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:1925:1: warning: 'll_file_ioctl' defined but not used [-Wunused-function]
>     ll_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>     ^~~~~~~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:1177:16: warning: 'll_file_write_iter' defined but not used [-Wunused-function]
>     static ssize_t ll_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
>                    ^~~~~~~~~~~~~~~~~~
>    drivers/staging/lustre/lustre/llite/file.c:1153:16: warning: 'll_file_read_iter' defined but not used [-Wunused-function]
>     static ssize_t ll_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>                    ^~~~~~~~~~~~~~~~~
> 
> vim +3117 drivers/staging/lustre/lustre/llite/file.c
> 
>   3111		}
>   3112	
>   3113		return rc;
>   3114	}
>   3115	
>   3116	/* -o localflock - only provides locally consistent flock locks */
> > 3117	struct const file_operations ll_file_operations = {
>   3118		.read_iter = ll_file_read_iter,
>   3119		.write_iter = ll_file_write_iter,
>   3120		.unlocked_ioctl = ll_file_ioctl,
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

This is a wrong patch. I have figured out that file operations shouldn't
be described as 'const'


More information about the devel mailing list