Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Dan Carpenter dan.carpenter at oracle.com
Sat Jul 29 10:52:27 UTC 2017


On Sat, Jul 29, 2017 at 11:16:11AM +0200, Marcus Wolf wrote:
> Hi Greg,
> 
> there is another patch from me (see subject). I sent it 19/07/2017.
> 
> Most probably, there is also something wrong with the patch, but maybe you can
> get it to work. 
> 
> The patch would be important. It doesn't fix any warnings or errors of static
> code analysis, but it fixes true implementation errors (wrong access of
> registers).

It does fix some static checker warnings for me...  ;)  And I've been
working on making add even more checker complaints inspired by that
patch but haven't finished.

> From my point of view, that is one of the most important changes to
> the code, we had during the last weeks.

The patch applies fine so no worries.

Anyway, just send some patches to yourself and try applying them with
`git am`.  That's what everyone is doing on the recieving end.

regards,
dan carpenter




More information about the devel mailing list