[PATCH] staging: net: wireless: fix badzero.cocci warnings

kbuild test robot lkp at intel.com
Sun Jul 23 08:25:28 UTC 2017


drivers/staging/esp8089/esp_mac80211.c:596:33-34: WARNING comparing pointer to 0

 Compare pointer-typed values to NULL rather than 0

Semantic patch information:
 This makes an effort to choose between !x and x == NULL.  !x is used
 if it has previously been used with the function used to initialize x.
 This relies on type information.  More type information can be obtained
 using the option -all_includes and the option -I to specify an
 include path.

Generated by: scripts/coccinelle/null/badzero.cocci

Fixes: 5ebdb57b0b15 ("staging: net: wireless: add ESP8089 WiFi driver")
CC: Quentin Schulz <quentin.schulz at free-electrons.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 esp_mac80211.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/esp8089/esp_mac80211.c
+++ b/drivers/staging/esp8089/esp_mac80211.c
@@ -593,7 +593,7 @@ static void hw_scan_timeout_report(struc
 	if (test_and_clear_bit(ESP_WL_FLAG_STOP_TXQ, &epub->wl.flags))
 		sip_trigger_txq_process(epub->sip);
 	/*check if normally complete or aborted like timeout/hw error */
-	aborted = (epub->wl.scan_req != 0);
+	aborted = (epub->wl.scan_req != NULL);
 
 	if (aborted)
 		epub->wl.scan_req = NULL;


More information about the devel mailing list