[PATCH] staging: lustre: mgc: Fix incorrect type in assignment

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Jul 11 17:13:12 UTC 2017


On Sat, Jul 01, 2017 at 05:26:52PM +0300, Kamal Heib wrote:
> Fix the following sparse warnings:
> mgc_request.c:68:25: warning: incorrect type in assignment (different base types)
> mgc_request.c:68:25:    expected unsigned long long [unsigned] [long] [long long] <noident>
> mgc_request.c:68:25:    got restricted __le64 [usertype] <noident>
> mgc_request.c:82:25: warning: incorrect type in assignment (different base types)
> mgc_request.c:82:25:    expected unsigned long long [unsigned] [long] [long long] <noident>
> mgc_request.c:82:25:    got restricted __le64 [usertype] <noident>
> 
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Signed-off-by: Kamal Heib <kamalheib1 at gmail.com>
> ---
>  drivers/staging/lustre/lustre/mgc/mgc_request.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index eee0b667a33c..93819bb84ef8 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -65,7 +65,7 @@ static int mgc_name2resid(char *name, int len, struct ldlm_res_id *res_id,
>  
>  	/* Always use the same endianness for the resid */
>  	memset(res_id, 0, sizeof(*res_id));
> -	res_id->name[0] = cpu_to_le64(resname);
> +	res_id->name[0] = resname;

Really?  What about that comment right above?  Are you _sure_ this patch
is correct?

thanks,

greg k-h


More information about the devel mailing list