[PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting removed

Joe Perches joe at perches.com
Mon Jul 10 13:39:43 UTC 2017


On Mon, 2017-07-10 at 10:09 +0300, AndyS wrote:
> removed undesired type casting. Warning was raised by checkpatch.pl
> This patch is for eudyptula challenge

False positive in checkpatch.
checkpatch does not handle floating point values.

> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
[]
> @@ -208,7 +208,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
>  	/* for SLEEP MODE */
>  	/* If setting by frequency, convert to a channel */
>  	if ((fwrq->e == 1) &&
> -	    (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
> +	    (fwrq->m >= 2.412e8) && (fwrq->m <= 2.487e8)) {
>  		int f = fwrq->m / 100000;
>  		int c = 0;
>  


More information about the devel mailing list