[PATCH] staging: bcm2835-audio: Strengthen build dependencies

Eric Anholt eric at anholt.net
Mon Jan 30 16:56:34 UTC 2017


Michael Zoran <mzoran at crowfest.net> writes:

> This driver makes no sense outside of ARM or ARM64.
> Add an explicit build dependency on:
> (ARM || ARM64 || COMPILE_TEST)
>
> Also set the default build to n
>
> Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> ---
>  drivers/staging/bcm2835-audio/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/bcm2835-audio/Kconfig b/drivers/staging/bcm2835-audio/Kconfig
> index 32a2ff9ef9b2..840faa21f665 100644
> --- a/drivers/staging/bcm2835-audio/Kconfig
> +++ b/drivers/staging/bcm2835-audio/Kconfig
> @@ -1,6 +1,8 @@
>  config SND_BCM2835
>          tristate "BCM2835 ALSA driver"
>          depends on ARCH_BCM2835 && BCM2835_VCHIQ && SND
> +	depends on (ARM || ARM64 || COMPILE_TEST)
> +	default n
>          select SND_PCM
>          help
>            Say Y or M if you want to support BCM2835 Alsa pcm card driver

We've already got a DEPENDS on ARCH_BCM2835, how would that be present
without one of those three being set?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20170130/880d8b1c/attachment.asc>


More information about the devel mailing list