[PATCH 1/1] iio: fixed symbolic permission references 'S_IRUGO | S_IWUSR'

Greg KH greg at kroah.com
Mon Jan 30 16:05:26 UTC 2017


On Mon, Jan 30, 2017 at 11:47:35AM +0100, Hartmut Knaack wrote:
> Artur Lorincz schrieb am 30.01.2017 um 11:10:
> > Replaced the symbolic permission references S_IRUGO and S_IWUSR with their
> > octal counterparts.
> 
> Hi Artur,
> patches concerning IIO should be sent to the linux-iio mailing list, and
> former maintainers of the file should be CC'ed.
> Now, regarding your patch, I am not convinced that this is an improvement.
> Those symbols are usually used to improve readability, which is not given
> with more or less magical numbers.

Sorry, but no, they should be replaced, as these are "well known" magic
numbers :)

thanks,

greg k-h


More information about the devel mailing list