[PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be non-atomic

Andy Shevchenko andriy.shevchenko at linux.intel.com
Thu Jan 19 10:46:12 UTC 2017


On Thu, 2017-01-19 at 10:49 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote:
> > First of all, fbtft in current state doesn't allow to override GPIOs
> > to be
> > optional, like "reset" one. It might be a bug somewhere, but rather
> > out of
> > scope of this fix.
> > 
> > Second, not all GPIOs available on the board would be SoC based,
> > some of them
> > might sit on I2C GPIO expanders, for example, on Intel
> > Edison/Arduino, and thus
> > any communication with them might sleep.
> > 
> > Besides that using udelay() and mdelay() is kinda resource wasteful.
> > 
> > Summarize all of the above, convert fbtft_reset() function to non-
> > atomic
> > variant by using gpio_set_value_cansleep(), usleep_range(), and
> > msleep().
> > 
> > Reviewed-by: Noralf Trønnes <noralf at tronnes.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> 
> Andy, this series came through with the charmap all corrupted and git
> didn't like them at all.  Can you fix up and resend?

Strange. I used usual git send-email. Okay, just resent (as v4).

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the devel mailing list