[PATCH 4/4] staging: greybus: audio: Ensure proper byte order

Vaibhav Agarwal vaibhav.sr at gmail.com
Mon Jan 16 11:51:05 UTC 2017


On Mon, Jan 16, 2017 at 4:17 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Sat, Jan 14, 2017 at 11:17:07PM +0530, Vaibhav Agarwal wrote:
>> @@ -656,13 +660,13 @@ static int gbaudio_tplg_create_enum_kctl(struct gbaudio_module_info *gb,
>>       gb_enum = &ctl->info.value.enumerated;
>>
>>       /* since count=1, and reg is dummy */
>> -     gbe->max = gb_enum->items;
>> +     gbe->max = le32_to_cpu(gb_enum->items);
>>       gbe->texts = gb_generate_enum_strings(gb, gb_enum);
>>
>>       /* debug enum info */
>>       dev_dbg(gb->dev, "Max:%d, name_length:%d\n", gb_enum->items,
>
> This is printing little endian max.  Just use gbe->max here.

Yes, this makes more sense. I should have noticed this earlier :(
Surely, I'll include this one & other suggested changes in v2 series.
Thanks Dan :)

--
vaibhav


More information about the devel mailing list