[PATCH] staging: fwserial: fix checkpatch alignment check

Greg KH gregkh at linuxfoundation.org
Tue Jan 3 17:26:56 UTC 2017


On Tue, Jan 03, 2017 at 10:16:00PM +0000, Abdul Rauf Mujahid wrote:
> 
> 
> On 01/03/2017 03:28 PM, Greg KH wrote:
> > On Sun, Jan 01, 2017 at 01:00:59AM +0000, Abdul Rauf wrote:
> >> Fix the following checks:
> >> Alignment should match open parenthesis.
> >>
> >> Signed-off-by: Abdul Rauf <abdulraufmujahid at gmail.com>
> >> ---
> >>  drivers/staging/fwserial/fwserial.c | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> >> index 41a49c8194e5..cb4e361fc545 100644
> >> --- a/drivers/staging/fwserial/fwserial.c
> >> +++ b/drivers/staging/fwserial/fwserial.c
> >> @@ -1344,8 +1344,9 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
> >>  	if (state == -1) {
> >>  		set_bit(STOP_TX, &port->flags);
> >>  		ret = wait_event_interruptible_timeout(port->wait_tx,
> >> -					       !test_bit(IN_TX, &port->flags),
> >> -					       10);
> >> +						       !test_bit(IN_TX,
> >> +								 &port->flags),
> >> +									    10);
> > Ick, please note that this doesn't look better than before :(
> >
> Sir, but it did fix one out of three checks :(

checkpatch.pl is a guide, use your brain when making changes, that's
why we have coding style rules in the first place :)

thanks,

greg k-h


More information about the devel mailing list