[PATCH v2] staging: greybus: svc_watchdog: replace printk() with pr_err()
Johan Hovold
johan at kernel.org
Mon Jan 2 13:58:06 UTC 2017
On Thu, Dec 22, 2016 at 04:22:03PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - "WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
> dev_err(dev, ... then pr_err(... to printk(KERN_ERR ."
>
> Signed-off-by: Emmanuil Chatzipetru <chatzi.emanuel at gmail.com>
> ---
> v2: Add svc_watchdog to the subject line
Thanks for the update.
Acked-by: Johan Hovold <johan at kernel.org>
> drivers/staging/greybus/svc_watchdog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/svc_watchdog.c b/drivers/staging/greybus/svc_watchdog.c
> index 5edff71f0773..d8af2d5d0025 100644
> --- a/drivers/staging/greybus/svc_watchdog.c
> +++ b/drivers/staging/greybus/svc_watchdog.c
> @@ -56,7 +56,7 @@ static void greybus_reset(struct work_struct *work)
> NULL,
> };
>
> - printk(KERN_ERR "svc_watchdog: calling \"%s %s\" to reset greybus network!\n",
> + pr_err("svc_watchdog: calling \"%s %s\" to reset greybus network!\n",
> argv[0], argv[1]);
> call_usermodehelper(start_path, argv, envp, UMH_WAIT_EXEC);
> }
More information about the devel
mailing list