[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

Joe Perches joe at perches.com
Tue Feb 28 20:34:11 UTC 2017


On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote:
> Use a single fmt string with appropriate verbs as conversion specifiers,
> followed by the original string literals and the integer argument
> instead of using a backslash to escape a new line embedded inbetween
> quoted string literals passed as fmt arguments to dev_err() invoked in
> drivers/staging/fbtft/fb_ssd1331.c.

trivia:

> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
> index 26f24e3..6d03041 100644
> --- a/drivers/staging/fbtft/fb_ssd1331.c
> +++ b/drivers/staging/fbtft/fb_ssd1331.c
> @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>  
>  	for (i = 0; i < 63; i++) {
>  		if (i > 0 && curves[i] < 2) {
> -			dev_err(par->info->device,
> -				"Illegal value in Grayscale Lookup Table at index %d. " \
> -				"Must be greater than 1\n", i);
> +			dev_err(par->info->device, "%s %d. %s\n",
> +				"Illegal value in Grayscale Lookup Table at index",

Most prefer the use of invalid not illegal.



More information about the devel mailing list