[PATCH 0/3] staging: vc04-services: Create new toplevel config VIDEOCORE

Michael Zoran mzoran at crowfest.net
Tue Feb 28 18:49:34 UTC 2017


The current toplevel menu item for vc04-services has this description:

Kernel to VideoCore communication interface for the
BCM2835 family of products.
Defaults to Y when the Broadcom Videocore services
are included in the build, N otherwise.

1. This isn't quite how things work today. Videocore is always included.
2. It's confusing and I don't believe anything about the brand VideoCore
   is specific to the BCM2835.

So what this patch set does is change the toplevel of the menu to be:

menuconfig VIDEOCORE
	bool "Broadcom VideoCore support"
	depends on HAS_DMA
	depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWAR
E)
	default y
	help
		Support for Broadcom VideoCore services including
		the BCM2835 family of products which is used
		by the Raspberry PI.
		
This makes it clear that VideoCore is a general set of Broadcom 
services that may not be exclusive to the BCM2835.

Also, I have kept the BCM2835_VCHIQ config, but changed it to a
simple config rather then a menuconfig.

Finally, I have changed the camera and the audio to select rather 
then depend on BCM2835_VCHIQ.  This allows BCM2835_VCHIQ to be changed
to say a module independenly, but yet the menu still works just like
the original description says that it should.  It is forced in if any
of the specific VideoCore services(like camera) are enabled.

Michael Zoran (3):
  staging: vc04_services: Create new CONFIG_VIDEOCORE setting for
    VideoCore services.
  staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on
    it.
  staging: bcm2835-camera: select BCM2835_VCHIQ rather then depending on
    it.

 drivers/staging/vc04_services/Kconfig                | 15 +++++++++++----
 drivers/staging/vc04_services/bcm2835-audio/Kconfig  |  3 ++-
 drivers/staging/vc04_services/bcm2835-camera/Kconfig |  2 +-
 3 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.11.0



More information about the devel mailing list