[PATCH 2/8] staging: ks7010: Fix checkpatch warning

Tobin C. Harding me at tobin.cc
Mon Feb 20 08:46:37 UTC 2017


Checkpatch emits WARNING: Comparisons should place the constant on
the right side of the test.

Move constant to the rights side of the test.

Signed-off-by: Tobin C. Harding <me at tobin.cc>
---
 drivers/staging/ks7010/ks_hostif.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 1fbd495..a976060 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -2608,13 +2608,12 @@ void hostif_sme_task(unsigned long dev)
 	DPRINTK(3, "\n");
 
 	if (priv->dev_state >= DEVICE_STATE_BOOT) {
-		if (0 < cnt_smeqbody(priv)
-		    && priv->dev_state >= DEVICE_STATE_BOOT) {
+		if (cnt_smeqbody(priv) > 0 && priv->dev_state >= DEVICE_STATE_BOOT) {
 			hostif_sme_execute(priv,
 					   priv->sme_i.event_buff[priv->sme_i.
 								  qhead]);
 			inc_smeqhead(priv);
-			if (0 < cnt_smeqbody(priv))
+			if (cnt_smeqbody(priv) > 0)
 				tasklet_schedule(&priv->sme_task);
 		}
 	}
-- 
2.7.4



More information about the devel mailing list