[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

Joe Perches joe at perches.com
Sat Feb 18 19:15:02 UTC 2017


On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote:
> Unnecessary parentheses as reported by checkpatch.pl
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
>  	}
>  
>  	/* bssid */
> -	memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> +	memcpy(&ap->bssid[0], &ap_info->bssid[0], ETH_ALEN);

It's often nicer to read if &(foo[0]) is converted to foo like:

	memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);



More information about the devel mailing list