[PATCH] staging: nvec: Fix incorrect type of i2c address

Marc Dietrich marvin24 at gmx.de
Tue Feb 14 10:39:37 UTC 2017


Am Montag, 13. Februar 2017, 09:35:19 CET schrieb Franck Demathieu:
> From: Franck Demathieu <franck.demathieu at intel.com>
> 
> The i2c address is unsigned according to the dt-bindings.
> Fix sparse issue (-Wtypesign):
> 
>   drivers/staging/nvec/nvec.c:781:35: warning: incorrect type in argument 3
> (different signedness) drivers/staging/nvec/nvec.c:781:35:    expected
> unsigned int [usertype] *out_value drivers/staging/nvec/nvec.c:781:35:   
> got int *<noident>
> 
> Signed-off-by: Franck Demathieu <fdemathieu at gmail.com>

looks correct. Thanks!

Acked-by: Marc Dietrich <marvin24 at gmx.de>

> ---
>  drivers/staging/nvec/nvec.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.h b/drivers/staging/nvec/nvec.h
> index c03ca8d..aa7c70e 100644
> --- a/drivers/staging/nvec/nvec.h
> +++ b/drivers/staging/nvec/nvec.h
> @@ -138,7 +138,7 @@ struct nvec_chip {
>  	struct device *dev;
>  	int gpio;
>  	int irq;
> -	int i2c_addr;
> +	u32 i2c_addr;
>  	void __iomem *base;
>  	struct clk *i2c_clk;
>  	struct reset_control *rst;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20170214/ba4cf8a4/attachment.asc>


More information about the devel mailing list