[PATCH] staging: sm750fb: Enclose macro arguments in parentheses

Matthieu Simon gmatthsim at gmail.com
Tue Feb 7 19:11:22 UTC 2017


checkpatch noticed possible precedence issues resulting in the definition
of PEEK32 and POKE32. So, these arguments should be enclosed in
parentheses.

Signed-off-by: Matthieu Simon <gmatthsim at gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
index e63b8b293816..a5f910344373 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drivers/staging/sm750fb/ddk750_chip.h
@@ -10,8 +10,8 @@
 #include <linux/uaccess.h>
 
 /* software control endianness */
-#define PEEK32(addr) readl(addr + mmio750)
-#define POKE32(addr, data) writel(data, addr + mmio750)
+#define PEEK32(addr) readl((addr) + mmio750)
+#define POKE32(addr, data) writel((data), (addr) + mmio750)
 
 extern void __iomem *mmio750;
 
-- 
Matthieu



More information about the devel mailing list