[patch] Staging: bcm2835-audio: fix an uninitialized return value

Dan Carpenter dan.carpenter at oracle.com
Tue Feb 7 13:17:34 UTC 2017


"ret" isn't necessarily initialized on the success path.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 9ac1f72a178e..b7922be4909c 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -432,6 +432,7 @@ static int bcm2835_audio_open_connection(struct bcm2835_alsa_stream *alsa_stream
 	alsa_stream->instance = instance;
 
 	LOG_DBG(" success !\n");
+	ret = 0;
 err_free_mem:
 	LOG_DBG(" .. OUT\n");
 


More information about the devel mailing list