[PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers
Sakari Ailus
sakari.ailus at linux.intel.com
Thu Dec 21 22:34:43 UTC 2017
Hi Andy and Dan,
On Wed, Dec 20, 2017 at 12:24:36PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 20, 2017 at 6:54 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
> >> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client)
> >> if (ret)
> >> gc2235_remove(client);
> >
> > This error handling is probably wrong...
> >
>
> Thanks for pointing to this, but I'm not going to fix this by the
> following reasons:
> 1. I admit the driver's code is ugly
> 2. It's staging code
> 3. My patch does not touch those lines
> 4. My purpose is to get it working first.
>
> Feel free to send a followup with a good clean up which I agree with.
Yeah, there's a lot of ugly stuff in this driver... I understand Andy's
patches address problems with functionality, let's make error handling
fixes separately.
So I'm applying these now.
Thanks!
--
Kind regards,
Sakari Ailus
sakari.ailus at linux.intel.com
More information about the devel
mailing list