[PATCH 2/3] staging: greybus: audio_codec.c: Fix multiple checkpatch errors

Greg KH gregkh at linuxfoundation.org
Thu Dec 21 17:15:16 UTC 2017


On Tue, Dec 19, 2017 at 09:55:05PM +0200, Kamal Heib wrote:
> This patch fixes the following errors found by checkpatch:
> 1- Prefer kernel type 'u32' over 'uint32_t'.
> 2- Space required around that ':'.
> 3- Alignment should match open parenthesis.
> 4- Don't use multiple blank lines.

When you have to list the different things a patch does, that's a huge
sign that it needs to be broken up.

Yeah, this is a small file, but please break this up into a patch
series.

thanks,

greg k-h


More information about the devel mailing list